ci: pin Foundry to v1.3.6 for reproducible formatting#91
Merged
Conversation
- test.yml: pin foundry-toolchain to v1.3.6 (was floating `nightly`) - Makefile: add `fmt` / `fmt-check` using the pinned version - CONTRIBUTING.md: document the formatting workflow Co-authored-by: OpenCode <opencode-noreply@coinbase.com>
Collaborator
🟡 Heimdall Review Status
|
ilikesymmetry
self-requested a review
July 15, 2026 17:44
ilikesymmetry
approved these changes
Jul 15, 2026
Collaborator
|
Review Error for ilikesymmetry @ 2026-07-15 17:45:22 UTC |
RuoHan-Chen
self-requested a review
July 15, 2026 17:53
RuoHan-Chen
approved these changes
Jul 15, 2026
Collaborator
|
Review Error for RuoHan-Chen @ 2026-07-15 17:54:38 UTC |
stevieraykatz
approved these changes
Jul 15, 2026
Collaborator
|
how many engineers does it take to pass heimdall: 3 apparently |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Pin CI's Foundry to
v1.3.6(was floatingnightly) and addmake fmt/make fmt-checkhelpers.Why
forge fmtoutput changes between Foundry versions, and CI usedversion: nightly— a moving target. Contributors on differing local Foundry versions produce formatting churn that pollutes diffs (e.g. unrelated call-wrapping changes) even when CI happens to pass. Pinning makesforge fmt --checkdeterministic.v1.3.6is the newest release under whichmainis already clean, so this PR reformats nothing and CI stays green on its own. (The formatter's call-wrapping behavior changed in v1.4.0.)Changes
.github/workflows/test.yml:version: nightly→version: "v1.3.6"Makefile:make fmt/make fmt-checkrun the pinned version (installed side-by-side; your default Foundry is untouched)CONTRIBUTING.md: formatting noteFollow-up
Feature branches should rebase on this and run
make fmtso their diffs show only the real changes.